Fix passing args in groupby plot (GH11805) #11891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! I guess we had very poor coverage for groupby plots previously. |
jorisvandenbossche
force-pushed
the
groupby-plot-kwargs
branch
from
b83127b to
d93c2d3
Compare
jorisvandenbossche
force-pushed
the
groupby-plot-kwargs
branch
from
d93c2d3 to
67a17c4
Compare
|
Very poor coverage indeed .. |
|
lgtm |
jorisvandenbossche
added a commit
that referenced
this pull request
Dec 28, 2015
Fix passing args in groupby plot (GH11805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11805
So probably all groupby plot calls that use kwargs are broken in 0.17.x.
@shoyer it was only a very small change actually!
Still need to add tests.